Multicall to func#90
Conversation
Avoids a class with a single method `execute()` at the expense of dropping the `__repr__()` support. This should make cython-izing that much simpler. Resolves pytest-dev#84
|
i wont be able to revie this this month, im of f the grid starting tommorow |
|
No worries ronny. Enjoy the blackout ;) |
|
Shrunk the range of hooks to use for benchmarking to get a simpler picture. Seems performance is the same or better when looking at min times but sometimes the mean can be a bit slower. It's negligable enough that I think the code cleanup outweighs that downside. I still don't get how instantiating |
|
@RonnyPfannschmidt @nicoddemus any opinions on this? |
I took a look at both versions of the code and I can't explain it either. As you, I would expect minimal difference to be negligible, but I'm also surprised that it can be slower some times. How slower are we talking about here?
I agree, great work! 👍 |
3 participants
For some weird reason the benchmark tests are turning out to be slightly slower for the
_multicallcases?I'm not sure if I'm testing something differently or if invoking 2 methods is faster then a single function?
I'm going to investigate deeper.